gh-145376: Fix various reference leaks#145377
Open
JelleZijlstra wants to merge 1 commit intopython:mainfrom
Open
gh-145376: Fix various reference leaks#145377JelleZijlstra wants to merge 1 commit intopython:mainfrom
JelleZijlstra wants to merge 1 commit intopython:mainfrom
Conversation
JelleZijlstra
requested review from
brettcannon,
ericsnowcurrently,
kumaraditya303,
ncoghlan and
warsaw
as code owners
JelleZijlstra
added
needs backport to 3.13
kumaraditya303
approved these changes
Mar 1, 2026
sergey-miryanov
approved these changes
Mar 1, 2026
sobolevn
reviewed
Mar 1, 2026
Member
|
Is there any improving the test suite to catch this kind of thing with the refleak bots? A quick glance suggests probably not, but it's worth at least getting a proper answer to the question written down :) |
Member
Author
|
I think a few of these could be caught with a test, yes. It doesn't feel extremely high value (these particular paths aren't likely to regress), but I can add some if you like. |
Member
|
I'm in no position to make that value judgement :). More test coverage is generally better, but if they're not worth it they're not worth it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All found by Codex.